Add newer rubies (primarily 2.4) to travis #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[1] Older webmock is not compatible with ruby 2.4 [2] webmock 2+ needs VCR 3.0.2+ [2] [3] Script from [2] to convert userinfo in uri to auth header (in cassettes) [4] An alternative script [5] thanks to cben for digging into this [1] Ruby 2.4.0 removed the closed? check in the conditional in: s.close if !s.closed? Webmock was changed to add close to StubSocket along with another change... ruby/ruby@f845a9e bblimke/webmock@8f2176a WebMock 2.3.1+ fixed the issue with ruby 2.4.0 by adding StubSocket#close. [2] vcr/vcr#570 (comment) [3] https://gist.github.com/glaszig/9170b1cf2186674faeead74a68606c5d [4] https://gist.github.com/ujh/594c99385b6cbe92e32b1bbfa8578a45 [5] ManageIQ/kubeclient#247
|
@bdunne the webmock issue should be fixed by the last commit |
jrafanie
changed the title
|
I'll close #8 and just have the change be included in this PR. I can re-open if needed |
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
May 4, 2017
[1] Older webmock is not compatible with ruby 2.4 [2] webmock 2+ needs VCR 3.0.2+ [2] [3] Script from [2] to convert userinfo in uri to auth header (in cassettes) [4] An alternative script [5] thanks to cben for digging into this [6] very similar to the change for foreman_api_client [1] Ruby 2.4.0 removed the closed? check in the conditional in: s.close if !s.closed? Webmock was changed to add close to StubSocket along with another change... ruby/ruby@f845a9e bblimke/webmock@8f2176a WebMock 2.3.1+ fixed the issue with ruby 2.4.0 by adding StubSocket#close. [2] vcr/vcr#570 (comment) [3] https://gist.github.com/glaszig/9170b1cf2186674faeead74a68606c5d [4] https://gist.github.com/ujh/594c99385b6cbe92e32b1bbfa8578a45 [5] ManageIQ/kubeclient#247 [6] ManageIQ/foreman_api_client#7
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/codeclimate/ruby-test-reporter/blob/master/CHANGELOG.md#v100-2016-11-03